PR #1538 merge to dev/gfdl#47
Merged
Merged
Conversation
The stochastic physics feature has been added in MOM6. The following are from Phil Pegion: The ocean stochastic physics has been re-coded such that there is a wrapper in config_src/external/OCEAN_stochastic_phyiscs that contains the calls to the external stochastic_physics repository. This has been added to support non-UFS applications of MOM6 where the stochastic_physics repository is not part of the build. The init and run procedures are called from src/core/MOM.F90. I have also created a new control structure stochastic_CS, which contains the logical variables, and random patterns which are then passed into src/parameterizations/vertical/MOM_diabadic_driver.F90 and src/parameterizations/vertical/MOM_energetic-PBL.F90. The writing of the ocean stochastic restarts sit in config_src/nuopc_cap/mom_cap.F90 Co-authored-by: pjpegion <Philip.Pegion@noaa.gov>
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #47 +/- ##
==========================================
Coverage 28.96% 28.96%
==========================================
Files 240 242 +2
Lines 71222 71324 +102
==========================================
+ Hits 20627 20660 +33
- Misses 50595 50664 +69
Continue to review full report at Codecov.
|
Member
Author
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14404 ✔️ 🟡 New parameters:
|
adcroft
approved these changes
Dec 21, 2021
This was referenced Jan 29, 2022
uwagura
pushed a commit
to uwagura/MOM6
that referenced
this pull request
Nov 4, 2025
* port main rk loop * typo and formatting * delete nan inducing copy * Dycore: NaN bugfix + minor diffs * hp upload after zero-initialization was causing random errors, likely in halo values. Now that zero-initialization is GPU-side, no need for upload. * Some nested do-concurrents were consolidated * Lots of whitespace fixes * Dycore: Mem reduction, first pass * Dycore: Mem cleanup second pass * Dycore: memcheck 3 * dycore: memcheck next * Dycore: memcheck, visc_rem and halos * dycore: Keep dz on GPU * Dycore: Remove [uv]_inst transfers * dycore: cs%eta fully on gpu * Dycore: Remove pbv copies A small change, but seems correct. pbv is input-only in step RK2, and is set outside in the main dycore loop (on CPU), followed by an upload. * dycore: memfix accel trim * Dycore: move up, vp down (and apparently an h download was redundant. looks ok, but havent 100% verified...) * dycore: Shift accels later in loop * dycore: tau[xy]_bot on GPU only * Dycore: [uv]_inst moved outside loop * Dycore: [uv]p, visc_rem_[uv] downshift * Dycore: [uvh]_av, uh, vh downshift Also some halo padding * Dycore: Remove multiple forcing/hp updates * Dycore: memfix [uv]_bc_accel * Dycore: Remove u_accel_bt and eta_pred transfers * Dycore: mem cleanup visc_rem_[uv] --------- Co-authored-by: Marshall Ward <marshall.ward@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge of the stochastic contribution (mom-ocean#1538) to dev/gfdl.
Resolved conflicts due to new stochastic arguments and transition of formerly optional arguments as mandatory.